Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPLT-810] Enable allowFontScaling by default for all citizens #6561

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[IOPLT-810] Enable allowFontScaling by default for all citizens #6561

wants to merge 17 commits into from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Dec 17, 2024 •
edited
Loading

Short description

This PR enables allowFontScaling by default for all citizens.

List of changes proposed in this pull request

  • Update io-app-design-system to 4.4.3
  • Minor refactoring to FimsSuccessBody and other screens to fix minor TS issues
  • Remove deprecated Itw… component to fix TS issue

Preview

larger-text.mp4

Related PRs

How to test

Increase or decrease the font size in the Accessibility section (Settings app) on both iOS and Android. Check that each part of the interface responds to the change.

@dmnplb dmnplb added a11y Activities related to accessibility Design System New visual language and reduction of previous UI clutter labels Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPLT-810

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.94%. Comparing base (9321272) to head (a8c80bc).

Files with missing lines Patch % Lines
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 0.00% 1 Missing ⚠️
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9321272) and HEAD (a8c80bc). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9321272) HEAD (a8c80bc)
10 6
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6561      +/-   ##
==========================================
- Coverage   49.29%   42.94%   -6.36%     
==========================================
  Files        1555     1409     -146     
  Lines       32119    29585    -2534     
  Branches     7312     6712     -600     
==========================================
- Hits        15834    12706    -3128     
- Misses      16236    16839     +603     
+ Partials       49       40       -9
Files with missing lines Coverage Δ
.../features/design-system/core/DSLegacyListItems.tsx 71.42% <ø> (ø)
ts/features/design-system/core/DSListItems.tsx 50.00% <ø> (ø)
...pay/configuration/screens/IbanOnboardingScreen.tsx 6.66% <ø> (ø)
...tures/messages/components/Home/DS/AvatarDouble.tsx 20.00% <100.00%> (-40.00%) ⬇️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 2.22% <0.00%> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 8.82% <0.00%> (-0.27%) ⬇️

... and 350 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9321272...a8c80bc. Read the comment docs.

LeleDallas
LeleDallas reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found also these cases with larger text:

Not now button Input number size
Screenshot 2024-12-23 at 09 10 06 Screenshot 2024-12-23 at 09 10 55

@dmnplb
Copy link
Contributor Author

dmnplb commented Dec 23, 2024

I found also these cases with larger text

@LeleDallas Not now is a part of an external package and it seems to be managed by a native element. I don't think we have control over what it looks like.

The input element should be examined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeleDallas LeleDallas LeleDallas left review comments

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a11y Activities related to accessibility Design System New visual language and reduction of previous UI clutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmnplb @LeleDallas